Serge Gautherie (JIRA)
2017-11-17 21:41:00 UTC
[ https://jira.reactos.org/browse/CORE-12589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=87680#comment-87680 ]
Serge Gautherie edited comment on CORE-12589 at 11/17/17 9:40 PM:
------------------------------------------------------------------
[^CORE-12589__WIN32_WINNT_WinBtrfs.patch] (= [BtrFs PR71|https://github.com/maharmstone/btrfs/pull/71])
{panel}
fsctl.c: it is _WIN32_WINNT, not WIN32_WINNT.
{panel}
--
Currently, "{{#if WIN32_WINNT >= 0x0600}}" is always false.
In this module, "{{_WIN32_WINNT == 0x0502}}".
So, this patch will only affect builds with forced "{{_WIN32_WINNT >= 0x0600}}".
I don't know whether such builds don't need this code or would currently be (unexpectedly) broken.
bq. Please report upstream/provide a patch upstream.
Agreed: this is why I opened this (as a) Sub-task.
-Could you manage upstream on my behalf, please?-
was (Author: serge gautherie):
[^CORE-12589__WIN32_WINNT_WinBtrfs.patch]
Currently, "{{#if WIN32_WINNT >= 0x0600}}" is always false.
In this module, "{{_WIN32_WINNT == 0x0502}}".
So, this patch will only affect builds with forced "{{_WIN32_WINNT >= 0x0600}}".
I don't know whether such builds don't need this code or would currently be (unexpectedly) broken.
bq. Please report upstream/provide a patch upstream.
Agreed: this is why I opened this (as a) Sub-task.
Could you manage upstream on my behalf, please?
This message was sent by Atlassian JIRA
(v7.3.2#73013)
Serge Gautherie edited comment on CORE-12589 at 11/17/17 9:40 PM:
------------------------------------------------------------------
[^CORE-12589__WIN32_WINNT_WinBtrfs.patch] (= [BtrFs PR71|https://github.com/maharmstone/btrfs/pull/71])
{panel}
fsctl.c: it is _WIN32_WINNT, not WIN32_WINNT.
{panel}
--
Currently, "{{#if WIN32_WINNT >= 0x0600}}" is always false.
In this module, "{{_WIN32_WINNT == 0x0502}}".
So, this patch will only affect builds with forced "{{_WIN32_WINNT >= 0x0600}}".
I don't know whether such builds don't need this code or would currently be (unexpectedly) broken.
bq. Please report upstream/provide a patch upstream.
Agreed: this is why I opened this (as a) Sub-task.
-Could you manage upstream on my behalf, please?-
was (Author: serge gautherie):
[^CORE-12589__WIN32_WINNT_WinBtrfs.patch]
Currently, "{{#if WIN32_WINNT >= 0x0600}}" is always false.
In this module, "{{_WIN32_WINNT == 0x0502}}".
So, this patch will only affect builds with forced "{{_WIN32_WINNT >= 0x0600}}".
I don't know whether such builds don't need this code or would currently be (unexpectedly) broken.
bq. Please report upstream/provide a patch upstream.
Agreed: this is why I opened this (as a) Sub-task.
Could you manage upstream on my behalf, please?
drivers/filesystems/btrfs/fsctl.c: 1 _WIN32_WINNT is misspelled as WIN32_WINNT
------------------------------------------------------------------------------
Key: CORE-12589
URL: https://jira.reactos.org/browse/CORE-12589
Project: Core ReactOS
Issue Type: Sub-task
Components: Filesystems
Reporter: Serge Gautherie
Assignee: Pierre Schweitzer
Priority: Minor
Attachments: CORE-12589__WIN32_WINNT_WinBtrfs.patch
[WinBtrfs (0.7)|https://github.com/maharmstone/btrfs] is sync'ed by [~heis spiter].
{noformat}
drivers/filesystems/btrfs/fsctl.c
2448 #if WIN32_WINNT >= 0x0600
{noformat}
was added upstream by [33ed052|https://github.com/maharmstone/btrfs/commit/33ed052be8be379a7a878adaf3407a501c293461].
--------------------------------------------------------------------------------
Key: CORE-12589
URL: https://jira.reactos.org/browse/CORE-12589
Project: Core ReactOS
Issue Type: Sub-task
Components: Filesystems
Reporter: Serge Gautherie
Assignee: Pierre Schweitzer
Priority: Minor
Attachments: CORE-12589__WIN32_WINNT_WinBtrfs.patch
[WinBtrfs (0.7)|https://github.com/maharmstone/btrfs] is sync'ed by [~heis spiter].
{noformat}
drivers/filesystems/btrfs/fsctl.c
2448 #if WIN32_WINNT >= 0x0600
{noformat}
was added upstream by [33ed052|https://github.com/maharmstone/btrfs/commit/33ed052be8be379a7a878adaf3407a501c293461].
This message was sent by Atlassian JIRA
(v7.3.2#73013)