Discussion:
[ros-bugs] [jira] (CORE-14607) VS2013 build fail on msvcrtex
HBelusca (JIRA)
2018-05-12 13:00:01 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-14607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103969#comment-103969 ]

HBelusca commented on CORE-14607:
---------------------------------

Sure I don't see why not [~usurp].
VS2013 build fail on msvcrtex
-----------------------------
Key: CORE-14607
URL: https://jira.reactos.org/browse/CORE-14607
Project: Core ReactOS
Issue Type: Bug
Reporter: Yuntian Zhang
Assignee: Bug Zilla
{noformat}
@echo off
:: CMake 3.11.1 x64
set path=C:\Program Files\CMake\bin;%path%
:: Visual Studio 2013 Professional Update 5 ver.12.0.40629.00
call "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\vcvarsall.bat" x86
call configure.cmd VSSolution
cd output-VS-i386-sln
msbuild -m REACTOS.sln /t:sdk\lib\crt\msvcrtex
pause
{noformat} 
{noformat}
c:\reactos\sdk\lib\crt\startup\crtexe.c(287): error C4013: '_ismbblead' undefined; assuming extern returning int [C:\reactos\output-VS-i386-sln\sdk\lib\crt\msvcrtex.vcxproj]
{noformat} 
{code:c}
#ifdef _MBCS
    if (_ismbblead (*lpszCommandLine))
{
if (lpszCommandLine) /* FIXME: Why this check? Should I check for *lpszCommandLine != 0 too? */
lpszCommandLine++;
}
#endif
{code}
MBCS stands for Multi Byte Character Set which is used for some Asian language where 1 byte can't encode all their characters. As such this is not a Unicode encoding.
Adding #undef _MBCS before #include "crtexe.c" in wcrtexe.c seems to fix the build on msvcrtex. Though I think we need to fix some header files.
--
This message was sent by Atlassian JIRA
(v7.3.2#73013)
Sylvain Petreolle (JIRA)
2018-05-12 10:12:00 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-14607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103964#comment-103964 ]

Sylvain Petreolle commented on CORE-14607:
------------------------------------------

Can we send patches to the CMake team ?
VS2013 build fail on msvcrtex
-----------------------------
Key: CORE-14607
URL: https://jira.reactos.org/browse/CORE-14607
Project: Core ReactOS
Issue Type: Bug
Reporter: Yuntian Zhang
Assignee: Bug Zilla
{noformat}
@echo off
:: CMake 3.11.1 x64
set path=C:\Program Files\CMake\bin;%path%
:: Visual Studio 2013 Professional Update 5 ver.12.0.40629.00
call "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\vcvarsall.bat" x86
call configure.cmd VSSolution
cd output-VS-i386-sln
msbuild -m REACTOS.sln /t:sdk\lib\crt\msvcrtex
pause
{noformat} 
{noformat}
c:\reactos\sdk\lib\crt\startup\crtexe.c(287): error C4013: '_ismbblead' undefined; assuming extern returning int [C:\reactos\output-VS-i386-sln\sdk\lib\crt\msvcrtex.vcxproj]
{noformat} 
{code:c}
#ifdef _MBCS
    if (_ismbblead (*lpszCommandLine))
{
if (lpszCommandLine) /* FIXME: Why this check? Should I check for *lpszCommandLine != 0 too? */
lpszCommandLine++;
}
#endif
{code}
MBCS stands for Multi Byte Character Set which is used for some Asian language where 1 byte can't encode all their characters. As such this is not a Unicode encoding.
Adding #undef _MBCS before #include "crtexe.c" in wcrtexe.c seems to fix the build on msvcrtex. Though I think we need to fix some header files.
--
This message was sent by Atlassian JIRA
(v7.3.2#73013)
Serge Gautherie (JIRA)
2018-05-12 00:23:00 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-14607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103942#comment-103942 ]

Serge Gautherie edited comment on CORE-14607 at 5/12/18 12:22 AM:
------------------------------------------------------------------

This is still ROSBE-81: I concur this needs to be foolproof'ed.

This issue relates to CORE-14326.


was (Author: serge gautherie):
This is still ROSBE-81: I concur this needs to be foolproof'ed.
VS2013 build fail on msvcrtex
-----------------------------
Key: CORE-14607
URL: https://jira.reactos.org/browse/CORE-14607
Project: Core ReactOS
Issue Type: Bug
Reporter: Yuntian Zhang
Assignee: Bug Zilla
{noformat}
@echo off
:: CMake 3.11.1 x64
set path=C:\Program Files\CMake\bin;%path%
:: Visual Studio 2013 Professional Update 5 ver.12.0.40629.00
call "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\vcvarsall.bat" x86
call configure.cmd VSSolution
cd output-VS-i386-sln
msbuild -m REACTOS.sln /t:sdk\lib\crt\msvcrtex
pause
{noformat} 
{noformat}
c:\reactos\sdk\lib\crt\startup\crtexe.c(287): error C4013: '_ismbblead' undefined; assuming extern returning int [C:\reactos\output-VS-i386-sln\sdk\lib\crt\msvcrtex.vcxproj]
{noformat} 
{code:c}
#ifdef _MBCS
    if (_ismbblead (*lpszCommandLine))
{
if (lpszCommandLine) /* FIXME: Why this check? Should I check for *lpszCommandLine != 0 too? */
lpszCommandLine++;
}
#endif
{code}
MBCS stands for Multi Byte Character Set which is used for some Asian language where 1 byte can't encode all their characters. As such this is not a Unicode encoding.
Adding #undef _MBCS before #include "crtexe.c" in wcrtexe.c seems to fix the build on msvcrtex. Though I think we need to fix some header files.
--
This message was sent by Atlassian JIRA
(v7.3.2#73013)
Serge Gautherie (JIRA)
2018-05-11 23:18:01 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-14607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103957#comment-103957 ]

Serge Gautherie commented on CORE-14607:
----------------------------------------

??Testing without RosBE is a waste of time.??

You disallow people to test issues they want to work on! Seriously?
VS2013 build fail on msvcrtex
-----------------------------
Key: CORE-14607
URL: https://jira.reactos.org/browse/CORE-14607
Project: Core ReactOS
Issue Type: Bug
Reporter: Yuntian Zhang
Assignee: Bug Zilla
{noformat}
@echo off
:: CMake 3.11.1 x64
set path=C:\Program Files\CMake\bin;%path%
:: Visual Studio 2013 Professional Update 5 ver.12.0.40629.00
call "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\vcvarsall.bat" x86
call configure.cmd VSSolution
cd output-VS-i386-sln
msbuild -m REACTOS.sln /t:sdk\lib\crt\msvcrtex
pause
{noformat} 
{noformat}
c:\reactos\sdk\lib\crt\startup\crtexe.c(287): error C4013: '_ismbblead' undefined; assuming extern returning int [C:\reactos\output-VS-i386-sln\sdk\lib\crt\msvcrtex.vcxproj]
{noformat} 
{code:c}
#ifdef _MBCS
    if (_ismbblead (*lpszCommandLine))
{
if (lpszCommandLine) /* FIXME: Why this check? Should I check for *lpszCommandLine != 0 too? */
lpszCommandLine++;
}
#endif
{code}
MBCS stands for Multi Byte Character Set which is used for some Asian language where 1 byte can't encode all their characters. As such this is not a Unicode encoding.
Adding #undef _MBCS before #include "crtexe.c" in wcrtexe.c seems to fix the build on msvcrtex. Though I think we need to fix some header files.
--
This message was sent by Atlassian JIRA
(v7.3.2#73013)
Mark Jansen (JIRA)
2018-05-11 08:00:00 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-14607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103944#comment-103944 ]

Mark Jansen commented on CORE-14607:
------------------------------------

Testing without RosBE is a waste of time.
VS2013 build fail on msvcrtex
-----------------------------
Key: CORE-14607
URL: https://jira.reactos.org/browse/CORE-14607
Project: Core ReactOS
Issue Type: Bug
Reporter: Yuntian Zhang
Assignee: Bug Zilla
{noformat}
@echo off
:: CMake 3.11.1 x64
set path=C:\Program Files\CMake\bin;%path%
:: Visual Studio 2013 Professional Update 5 ver.12.0.40629.00
call "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\vcvarsall.bat" x86
call configure.cmd VSSolution
cd output-VS-i386-sln
msbuild -m REACTOS.sln /t:sdk\lib\crt\msvcrtex
pause
{noformat} 
{noformat}
c:\reactos\sdk\lib\crt\startup\crtexe.c(287): error C4013: '_ismbblead' undefined; assuming extern returning int [C:\reactos\output-VS-i386-sln\sdk\lib\crt\msvcrtex.vcxproj]
{noformat} 
{code:c}
#ifdef _MBCS
    if (_ismbblead (*lpszCommandLine))
{
if (lpszCommandLine) /* FIXME: Why this check? Should I check for *lpszCommandLine != 0 too? */
lpszCommandLine++;
}
#endif
{code}
MBCS stands for Multi Byte Character Set which is used for some Asian language where 1 byte can't encode all their characters. As such this is not a Unicode encoding.
Adding #undef _MBCS before #include "crtexe.c" in wcrtexe.c seems to fix the build on msvcrtex. Though I think we need to fix some header files.
--
This message was sent by Atlassian JIRA
(v7.3.2#73013)
Serge Gautherie (JIRA)
2018-05-11 03:22:00 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-14607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103942#comment-103942 ]

Serge Gautherie edited comment on CORE-14607 at 5/11/18 3:21 AM:
-----------------------------------------------------------------

This is still ROSBE-81: I concur this needs to be foolproof'ed.


was (Author: serge gautherie):
This is ROSBE-81 again: still not foolproof.
VS2013 build fail on msvcrtex
-----------------------------
Key: CORE-14607
URL: https://jira.reactos.org/browse/CORE-14607
Project: Core ReactOS
Issue Type: Bug
Reporter: Yuntian Zhang
Assignee: Bug Zilla
{noformat}
@echo off
:: CMake 3.11.1 x64
set path=C:\Program Files\CMake\bin;%path%
:: Visual Studio 2013 Professional Update 5 ver.12.0.40629.00
call "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\vcvarsall.bat" x86
call configure.cmd VSSolution
cd output-VS-i386-sln
msbuild -m REACTOS.sln /t:sdk\lib\crt\msvcrtex
pause
{noformat} 
{noformat}
c:\reactos\sdk\lib\crt\startup\crtexe.c(287): error C4013: '_ismbblead' undefined; assuming extern returning int [C:\reactos\output-VS-i386-sln\sdk\lib\crt\msvcrtex.vcxproj]
{noformat} 
{code:c}
#ifdef _MBCS
    if (_ismbblead (*lpszCommandLine))
{
if (lpszCommandLine) /* FIXME: Why this check? Should I check for *lpszCommandLine != 0 too? */
lpszCommandLine++;
}
#endif
{code}
MBCS stands for Multi Byte Character Set which is used for some Asian language where 1 byte can't encode all their characters. As such this is not a Unicode encoding.
Adding #undef _MBCS before #include "crtexe.c" in wcrtexe.c seems to fix the build on msvcrtex. Though I think we need to fix some header files.
--
This message was sent by Atlassian JIRA
(v7.3.2#73013)
Serge Gautherie (JIRA)
2018-05-11 03:13:00 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-14607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103943#comment-103943 ]

Serge Gautherie commented on CORE-14607:
----------------------------------------

Reproduced while testing CORE-11836 without RosBE.
VS2013 build fail on msvcrtex
-----------------------------
Key: CORE-14607
URL: https://jira.reactos.org/browse/CORE-14607
Project: Core ReactOS
Issue Type: Bug
Reporter: Yuntian Zhang
Assignee: Bug Zilla
{noformat}
@echo off
:: CMake 3.11.1 x64
set path=C:\Program Files\CMake\bin;%path%
:: Visual Studio 2013 Professional Update 5 ver.12.0.40629.00
call "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\vcvarsall.bat" x86
call configure.cmd VSSolution
cd output-VS-i386-sln
msbuild -m REACTOS.sln /t:sdk\lib\crt\msvcrtex
pause
{noformat} 
{noformat}
c:\reactos\sdk\lib\crt\startup\crtexe.c(287): error C4013: '_ismbblead' undefined; assuming extern returning int [C:\reactos\output-VS-i386-sln\sdk\lib\crt\msvcrtex.vcxproj]
{noformat} 
{code:c}
#ifdef _MBCS
    if (_ismbblead (*lpszCommandLine))
{
if (lpszCommandLine) /* FIXME: Why this check? Should I check for *lpszCommandLine != 0 too? */
lpszCommandLine++;
}
#endif
{code}
MBCS stands for Multi Byte Character Set which is used for some Asian language where 1 byte can't encode all their characters. As such this is not a Unicode encoding.
Adding #undef _MBCS before #include "crtexe.c" in wcrtexe.c seems to fix the build on msvcrtex. Though I think we need to fix some header files.
--
This message was sent by Atlassian JIRA
(v7.3.2#73013)
Serge Gautherie (JIRA)
2018-05-11 03:11:01 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-14607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103942#comment-103942 ]

Serge Gautherie commented on CORE-14607:
----------------------------------------

This is ROSBE-81 again: still not foolproof.
VS2013 build fail on msvcrtex
-----------------------------
Key: CORE-14607
URL: https://jira.reactos.org/browse/CORE-14607
Project: Core ReactOS
Issue Type: Bug
Reporter: Yuntian Zhang
Assignee: Bug Zilla
{noformat}
@echo off
:: CMake 3.11.1 x64
set path=C:\Program Files\CMake\bin;%path%
:: Visual Studio 2013 Professional Update 5 ver.12.0.40629.00
call "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\vcvarsall.bat" x86
call configure.cmd VSSolution
cd output-VS-i386-sln
msbuild -m REACTOS.sln /t:sdk\lib\crt\msvcrtex
pause
{noformat} 
{noformat}
c:\reactos\sdk\lib\crt\startup\crtexe.c(287): error C4013: '_ismbblead' undefined; assuming extern returning int [C:\reactos\output-VS-i386-sln\sdk\lib\crt\msvcrtex.vcxproj]
{noformat} 
{code:c}
#ifdef _MBCS
    if (_ismbblead (*lpszCommandLine))
{
if (lpszCommandLine) /* FIXME: Why this check? Should I check for *lpszCommandLine != 0 too? */
lpszCommandLine++;
}
#endif
{code}
MBCS stands for Multi Byte Character Set which is used for some Asian language where 1 byte can't encode all their characters. As such this is not a Unicode encoding.
Adding #undef _MBCS before #include "crtexe.c" in wcrtexe.c seems to fix the build on msvcrtex. Though I think we need to fix some header files.
--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Loading...