Discussion:
[ros-bugs] [jira] (CORE-14622) [comctl32] Regression Background Colour is displayed grey but should be white (where no text is) in setup wizard of Antivir
reactosfanboy (JIRA)
2018-05-13 02:22:01 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-14622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

reactosfanboy updated CORE-14622:
---------------------------------
Priority: Minor (was: Major)

And please ignore the very first screen of that setup. To make that one displaying correctly an installed Gecko is needed.

The ticket aims for the third and the last screen of that setup only.
[comctl32] Regression Background Colour is displayed grey but should be white (where no text is) in setup wizard of Antivir
---------------------------------------------------------------------------------------------------------------------------
Key: CORE-14622
URL: https://jira.reactos.org/browse/CORE-14622
Project: Core ReactOS
Issue Type: Bug
Reporter: reactosfanboy
Assignee: Bug Zilla
Priority: Minor
Labels: REGRESSION
Attachments: 0.4.8-dev-56-g11049bd_untilCurrentHead_greyBackgroundErronouslyThatShouldBeWhite.webm, 2k3sp2_ok.webm, ThirdScreenOfSetupShowsGreyBackGroundErronouslyWhereNoTextIs.png, backgroundcolor-regressiontest.txt, r73441-ok.webm, r74136.webm
0.4.9-dev-787-g7673837 gcc dbg
"Avira Antivir Personal 6.35.00.243" from http://www.oldversion.com/windows/avira-antivir-6-35-00-243
We have a regression in comctl32 that was introduced with [SVN74136|https://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/propsheet.c?r1=74136&r2=74135&pathrev=74136] comctl32/propsheet [~hbelusca]
[^ThirdScreenOfSetupShowsGreyBackGroundErronouslyWhereNoTextIs.png]
Most of that screen should be white.
It has to look like in [^2k3sp2_ok.webm]
-[SVN74136|https://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/propsheet.c?r1=74136&r2=74135&pathrev=74136] which broke it
-[0.4.8-dev-56-g11049bd|https://git.reactos.org/?p=reactos.git;a=commitdiff;h=11049bd] which already fixed part of it again, see CORE-13929
[^r73441-ok.webm]
[^r74136.webm] most broken
[^0.4.8-dev-56-g11049bd_untilCurrentHead_greyBackgroundErronouslyThatShouldBeWhite.webm]
The videos show multiple issues, some of them can be fixed by enforcing a repaint (moving on and off screen). For example the wrong background in the header sections and the initially not painted pictures in the header section. *Those issues are not part of this ticket*.
*The ticket is solely about the wrong background colour that is grey and should be white, and this issue can not be fixed by an enforced repaint*
--
This message was sent by Atlassian JIRA
(v7.3.2#73013)
reactosfanboy (JIRA)
2018-05-13 02:07:00 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-14622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

reactosfanboy updated CORE-14622:
---------------------------------
Description:
0.4.9-dev-787-g7673837 gcc dbg
"Avira Antivir Personal 6.35.00.243" from http://www.oldversion.com/windows/avira-antivir-6-35-00-243

We have a regression in comctl32 that was introduced with [SVN74136|https://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/propsheet.c?r1=74136&r2=74135&pathrev=74136] comctl32/propsheet [~hbelusca]

[^ThirdScreenOfSetupShowsGreyBackGroundErronouslyWhereNoTextIs.png]
Most of that screen should be white.

It has to look like in [^2k3sp2_ok.webm]

[^backgroundcolor-regressiontest.txt] points to 2 interesting commits in comctl32, both from [~hbelusca]:
-[SVN74136|https://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/propsheet.c?r1=74136&r2=74135&pathrev=74136] which broke it
-[0.4.8-dev-56-g11049bd|https://git.reactos.org/?p=reactos.git;a=commitdiff;h=11049bd] which already fixed part of it again, see CORE-13929


Please watch these videos carefully:
[^r73441-ok.webm]
[^r74136.webm] most broken
[^0.4.8-dev-56-g11049bd_untilCurrentHead_greyBackgroundErronouslyThatShouldBeWhite.webm]


The videos show multiple issues, some of them can be fixed by enforcing a repaint (moving on and off screen). For example the wrong background in the header sections and the initially not painted pictures in the header section. *Those issues are not part of this ticket*.

*The ticket is solely about the wrong background colour that is grey and should be white, and this issue can not be fixed by an enforced repaint*

was:
0.4.9-dev-787-g7673837 gcc dbg
"Avira Antivir Personal 6.35.00.243" from http://www.oldversion.com/windows/avira-antivir-6-35-00-243

We have a regression in comctl32 that was introduced with [SVN74136|https://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/propsheet.c?r1=74136&r2=74135&pathrev=74136] comctl32/propsheet [~hbelusca]

[^ThirdScreenOfSetupShowsGreyBackGroundErronouslyWhereNoTextIs.png]
Most of that screen should be white.

It has to look like in [^2k3sp2_ok.webm]

[^backgroundcolor-regressiontest.txt] points to 2 interesting commits in comctl32, both from [~hbelusca]:
-[SVN74136|https://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/propsheet.c?r1=74136&r2=74135&pathrev=74136] which broke it
-[0.4.8-dev-56-g11049bd|https://git.reactos.org/?p=reactos.git;a=commitdiff;h=11049bd] which already fixed part of it again, see CORE-13929


Please watch these videos carefully:
[^r73441-ok.webm]
[^r74136.webm] most broken
[^0.4.8-dev-56-g11049bd_untilCurrentHead_greyBackgroundErronouslyThatShouldBeWhite.webm]


The videos show multiple issues, some of them can be fixed by enforcing a repaint (moving on and off screen). For example the wrong background in the header sections and the initially not painted pictures in the header section. *Those issues are not part of this ticket*.

*The ticket is solely about the wrong background colour that is grey and should be white*
[comctl32] Regression Background Colour is displayed grey but should be white (where no text is) in setup wizard of Antivir
---------------------------------------------------------------------------------------------------------------------------
Key: CORE-14622
URL: https://jira.reactos.org/browse/CORE-14622
Project: Core ReactOS
Issue Type: Bug
Reporter: reactosfanboy
Assignee: Bug Zilla
Labels: REGRESSION
Attachments: 0.4.8-dev-56-g11049bd_untilCurrentHead_greyBackgroundErronouslyThatShouldBeWhite.webm, 2k3sp2_ok.webm, ThirdScreenOfSetupShowsGreyBackGroundErronouslyWhereNoTextIs.png, backgroundcolor-regressiontest.txt, r73441-ok.webm, r74136.webm
0.4.9-dev-787-g7673837 gcc dbg
"Avira Antivir Personal 6.35.00.243" from http://www.oldversion.com/windows/avira-antivir-6-35-00-243
We have a regression in comctl32 that was introduced with [SVN74136|https://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/propsheet.c?r1=74136&r2=74135&pathrev=74136] comctl32/propsheet [~hbelusca]
[^ThirdScreenOfSetupShowsGreyBackGroundErronouslyWhereNoTextIs.png]
Most of that screen should be white.
It has to look like in [^2k3sp2_ok.webm]
-[SVN74136|https://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/propsheet.c?r1=74136&r2=74135&pathrev=74136] which broke it
-[0.4.8-dev-56-g11049bd|https://git.reactos.org/?p=reactos.git;a=commitdiff;h=11049bd] which already fixed part of it again, see CORE-13929
[^r73441-ok.webm]
[^r74136.webm] most broken
[^0.4.8-dev-56-g11049bd_untilCurrentHead_greyBackgroundErronouslyThatShouldBeWhite.webm]
The videos show multiple issues, some of them can be fixed by enforcing a repaint (moving on and off screen). For example the wrong background in the header sections and the initially not painted pictures in the header section. *Those issues are not part of this ticket*.
*The ticket is solely about the wrong background colour that is grey and should be white, and this issue can not be fixed by an enforced repaint*
--
This message was sent by Atlassian JIRA
(v7.3.2#73013)
reactosfanboy (JIRA)
2018-05-13 02:04:01 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-14622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

reactosfanboy updated CORE-14622:
---------------------------------
Guilty Revision: 74136
Module: comctl32
Labels: REGRESSION (was: )
Guilty Commit: b1b42795a94d8e3cb69e2d9e5bd0af4929610361

[~Hbelusca] I know comctl32 is not funny to touch, but you already digged into the two related commits, so most likely you are most skilled here.
[comctl32] Regression Background Colour is displayed grey but should be white (where no text is) in setup wizard of Antivir
---------------------------------------------------------------------------------------------------------------------------
Key: CORE-14622
URL: https://jira.reactos.org/browse/CORE-14622
Project: Core ReactOS
Issue Type: Bug
Reporter: reactosfanboy
Assignee: Bug Zilla
Labels: REGRESSION
Attachments: 0.4.8-dev-56-g11049bd_untilCurrentHead_greyBackgroundErronouslyThatShouldBeWhite.webm, 2k3sp2_ok.webm, ThirdScreenOfSetupShowsGreyBackGroundErronouslyWhereNoTextIs.png, backgroundcolor-regressiontest.txt, r73441-ok.webm, r74136.webm
0.4.9-dev-787-g7673837 gcc dbg
"Avira Antivir Personal 6.35.00.243" from http://www.oldversion.com/windows/avira-antivir-6-35-00-243
We have a regression in comctl32 that was introduced with [SVN74136|https://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/propsheet.c?r1=74136&r2=74135&pathrev=74136] comctl32/propsheet [~hbelusca]
[^ThirdScreenOfSetupShowsGreyBackGroundErronouslyWhereNoTextIs.png]
Most of that screen should be white.
It has to look like in [^2k3sp2_ok.webm]
-[SVN74136|https://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/propsheet.c?r1=74136&r2=74135&pathrev=74136] which broke it
-[0.4.8-dev-56-g11049bd|https://git.reactos.org/?p=reactos.git;a=commitdiff;h=11049bd] which already fixed part of it again, see CORE-13929
[^r73441-ok.webm]
[^r74136.webm] most broken
[^0.4.8-dev-56-g11049bd_untilCurrentHead_greyBackgroundErronouslyThatShouldBeWhite.webm]
The videos show multiple issues, some of them can be fixed by enforcing a repaint (moving on and off screen). For example the wrong background in the header sections and the initially not painted pictures in the header section. *Those issues are not part of this ticket*.
*The ticket is solely about the wrong background colour that is grey and should be white*
--
This message was sent by Atlassian JIRA
(v7.3.2#73013)
reactosfanboy (JIRA)
2018-05-13 02:00:01 UTC
Permalink
reactosfanboy created CORE-14622:
------------------------------------

Summary: [comctl32] Regression Background Colour is displayed grey but should be white (where no text is) in setup wizard of Antivir
Key: CORE-14622
URL: https://jira.reactos.org/browse/CORE-14622
Project: Core ReactOS
Issue Type: Bug
Reporter: reactosfanboy
Assignee: Bug Zilla
Attachments: 0.4.8-dev-56-g11049bd_untilCurrentHead_greyBackgroundErronouslyThatShouldBeWhite.webm, 2k3sp2_ok.webm, ThirdScreenOfSetupShowsGreyBackGroundErronouslyWhereNoTextIs.png, backgroundcolor-regressiontest.txt, r73441-ok.webm, r74136.webm

0.4.9-dev-787-g7673837 gcc dbg
"Avira Antivir Personal 6.35.00.243" from http://www.oldversion.com/windows/avira-antivir-6-35-00-243

We have a regression in comctl32 that was introduced with [SVN74136|https://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/propsheet.c?r1=74136&r2=74135&pathrev=74136] comctl32/propsheet [~hbelusca]

[^ThirdScreenOfSetupShowsGreyBackGroundErronouslyWhereNoTextIs.png]
Most of that screen should be white.

It has to look like in [^2k3sp2_ok.webm]

[^backgroundcolor-regressiontest.txt] points to 2 interesting commits in comctl32, both from [~hbelusca]:
-[SVN74136|https://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/propsheet.c?r1=74136&r2=74135&pathrev=74136] which broke it
-[0.4.8-dev-56-g11049bd|https://git.reactos.org/?p=reactos.git;a=commitdiff;h=11049bd] which already fixed part of it again, see CORE-13929


Please watch these videos carefully:
[^r73441-ok.webm]
[^r74136.webm] most broken
[^0.4.8-dev-56-g11049bd_untilCurrentHead_greyBackgroundErronouslyThatShouldBeWhite.webm]


The videos show multiple issues, some of them can be fixed by enforcing a repaint (moving on and off screen). For example the wrong background in the header sections and the initially not painted pictures in the header section. *Those issues are not part of this ticket*.

*The ticket is solely about the wrong background colour that is grey and should be white*



--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Loading...