Discussion:
[jira] (CORE-6865) shell: incorrectly displayed type of file in file properties
(too old to reply)
Edijs Kolesnikovics (JIRA)
2013-04-03 10:16:03 UTC
Permalink
[ http://jira.reactos.org/browse/CORE-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=51306#comment-51306 ]

Edijs Kolesnikovics commented on CORE-6865:
-------------------------------------------

Yes, this fix seems to be correct. So, there remains some other bugs (used ANSI functions where UNICODE ones should be used).
shell: incorrectly displayed type of file in file properties
------------------------------------------------------------
Key: CORE-6865
URL: http://jira.reactos.org/browse/CORE-6865
Project: Core ReactOS
Issue Type: Bug
Components: Shell
Affects Versions: TRUNK
Reporter: Edijs Kolesnikovics
Assignee: Bug Zilla
Priority: Minor
Labels: PATCH
Fix For: TRUNK
Attachments: bug vs fix.png, shell32- russian winrar type of file1.patch
File Properties contains "????? WinRAR (.rar)" under 'Type of file' when russian version of WinRAR (v4.20) installed. However, regedit shows 'Aрхив WinRAR' in HKCR\WinRAR default value.
However, I do not know how to find if Windows uses SHGFI_USEFILEATTRIBUTES flag when showing file properties dialog, but still proposing a patch to fix this issue.
Patch by Edijs Kolesnikovičs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Timo Kreuzer (JIRA)
2014-05-24 20:40:10 UTC
Permalink
[ http://jira.reactos.org/browse/CORE-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timo Kreuzer reassigned CORE-6865:
----------------------------------

Assignee: David Quintana (was: Bug Zilla)
shell: incorrectly displayed type of file in file properties
------------------------------------------------------------
Key: CORE-6865
URL: http://jira.reactos.org/browse/CORE-6865
Project: Core ReactOS
Issue Type: Bug
Components: Shell
Affects Versions: TRUNK
Reporter: Edijs Kolesnikovics
Assignee: David Quintana
Priority: Minor
Labels: PATCH
Fix For: TRUNK
Attachments: bug vs fix.png, shell32- russian winrar type of file1.patch
File Properties contains "????? WinRAR (.rar)" under 'Type of file' when russian version of WinRAR (v4.20) installed. However, regedit shows 'Aрхив WinRAR' in HKCR\WinRAR default value.
However, I do not know how to find if Windows uses SHGFI_USEFILEATTRIBUTES flag when showing file properties dialog, but still proposing a patch to fix this issue.
Patch by Edijs Kolesnikovičs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
David Quintana (JIRA)
2014-12-19 15:51:42 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63076#comment-63076 ]

David Quintana commented on CORE-6865:
--------------------------------------

I just looked at the patch, and I'm not sure that the patch is correct. It sounds to me like a workaround to hide a bug, instead of fixing the actual bug.
shell: incorrectly displayed type of file in file properties
------------------------------------------------------------
Key: CORE-6865
URL: https://jira.reactos.org/browse/CORE-6865
Project: Core ReactOS
Issue Type: Bug
Components: Shell
Affects Versions: TRUNK
Reporter: Edijs Kolesnikovics
Assignee: David Quintana
Priority: Minor
Labels: PATCH
Fix For: TRUNK
Attachments: bug vs fix.png, shell32- russian winrar type of file1.patch
File Properties contains "????? WinRAR (.rar)" under 'Type of file' when russian version of WinRAR (v4.20) installed. However, regedit shows 'Aрхив WinRAR' in HKCR\WinRAR default value.
However, I do not know how to find if Windows uses SHGFI_USEFILEATTRIBUTES flag when showing file properties dialog, but still proposing a patch to fix this issue.
Patch by Edijs Kolesnikovičs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
David Quintana (JIRA)
2014-12-19 15:51:43 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63076#comment-63076 ]

David Quintana edited comment on CORE-6865 at 12/19/14 3:51 PM:
----------------------------------------------------------------

I just looked at the patch, and I'm not sure that the patch is correct. It sounds to me like a workaround to hide a bug, instead of fixing the actual bug.

[Edit: I pressed submit too soon]

That said, is the bug still valid?

was (Author: gigaherz):
I just looked at the patch, and I'm not sure that the patch is correct. It sounds to me like a workaround to hide a bug, instead of fixing the actual bug.
shell: incorrectly displayed type of file in file properties
------------------------------------------------------------
Key: CORE-6865
URL: https://jira.reactos.org/browse/CORE-6865
Project: Core ReactOS
Issue Type: Bug
Components: Shell
Affects Versions: TRUNK
Reporter: Edijs Kolesnikovics
Assignee: David Quintana
Priority: Minor
Labels: PATCH
Fix For: TRUNK
Attachments: bug vs fix.png, shell32- russian winrar type of file1.patch
File Properties contains "????? WinRAR (.rar)" under 'Type of file' when russian version of WinRAR (v4.20) installed. However, regedit shows 'Aрхив WinRAR' in HKCR\WinRAR default value.
However, I do not know how to find if Windows uses SHGFI_USEFILEATTRIBUTES flag when showing file properties dialog, but still proposing a patch to fix this issue.
Patch by Edijs Kolesnikovičs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Giannis Adamopoulos (JIRA)
2015-10-28 17:19:50 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=73156#comment-73156 ]

Giannis Adamopoulos commented on CORE-6865:
-------------------------------------------

This patch is hacky, the correct way is to fix SHGetFileInfoW.
shell: incorrectly displayed type of file in file properties
------------------------------------------------------------
Key: CORE-6865
URL: https://jira.reactos.org/browse/CORE-6865
Project: Core ReactOS
Issue Type: Bug
Components: Shell
Affects Versions: TRUNK
Reporter: Edijs Kolesnikovics
Assignee: David Quintana
Priority: Minor
Labels: PATCH
Fix For: TRUNK
Attachments: bug vs fix.png, shell32- russian winrar type of file1.patch
File Properties contains "????? WinRAR (.rar)" under 'Type of file' when russian version of WinRAR (v4.20) installed. However, regedit shows 'Aрхив WinRAR' in HKCR\WinRAR default value.
However, I do not know how to find if Windows uses SHGFI_USEFILEATTRIBUTES flag when showing file properties dialog, but still proposing a patch to fix this issue.
Patch by Edijs Kolesnikovičs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Robert Naumann (JIRA)
2016-07-29 10:35:50 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=80594#comment-80594 ]

Robert Naumann commented on CORE-6865:
--------------------------------------

When this function is the culprit, we should take a look at CORE-7159
shell: incorrectly displayed type of file in file properties
------------------------------------------------------------
Key: CORE-6865
URL: https://jira.reactos.org/browse/CORE-6865
Project: Core ReactOS
Issue Type: Bug
Components: Shell
Affects Versions: TRUNK
Reporter: Edijs Kolesnikovics
Assignee: David Quintana
Priority: Minor
Labels: PATCH
Fix For: TRUNK
Attachments: bug vs fix.png, shell32- russian winrar type of file1.patch
File Properties contains "????? WinRAR (.rar)" under 'Type of file' when russian version of WinRAR (v4.20) installed. However, regedit shows 'Aрхив WinRAR' in HKCR\WinRAR default value.
However, I do not know how to find if Windows uses SHGFI_USEFILEATTRIBUTES flag when showing file properties dialog, but still proposing a patch to fix this issue.
Patch by Edijs Kolesnikovičs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
HBelusca (JIRA)
2016-07-29 12:35:49 UTC
Permalink
[ https://jira.reactos.org/browse/CORE-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

HBelusca updated CORE-6865:
---------------------------

Fix Version/s: (was: TRUNK)
shell: incorrectly displayed type of file in file properties
------------------------------------------------------------
Key: CORE-6865
URL: https://jira.reactos.org/browse/CORE-6865
Project: Core ReactOS
Issue Type: Bug
Components: Shell
Affects Versions: TRUNK
Reporter: Edijs Kolesnikovics
Assignee: David Quintana
Priority: Minor
Labels: PATCH
Attachments: bug vs fix.png, shell32- russian winrar type of file1.patch
File Properties contains "????? WinRAR (.rar)" under 'Type of file' when russian version of WinRAR (v4.20) installed. However, regedit shows 'Aрхив WinRAR' in HKCR\WinRAR default value.
However, I do not know how to find if Windows uses SHGFI_USEFILEATTRIBUTES flag when showing file properties dialog, but still proposing a patch to fix this issue.
Patch by Edijs Kolesnikovičs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Loading...