[ros-bugs] [jira] (CORE-12906) Folder Options: File Types: Implement

Discussion:

Samuel Serapion (JIRA)

2017-03-09 20:38:01 UTC

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Samuel Serapion updated CORE-12906:
-----------------------------------
Component/s: Shell

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Attachments: edit-file-type.png, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Giannis Adamopoulos (JIRA)

2017-03-12 09:32:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Giannis Adamopoulos updated CORE-12906:
---------------------------------------
Module: shell32

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Jared Smudde (JIRA)

2017-04-25 01:47:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jared Smudde updated CORE-12906:
--------------------------------
Labels: PATCH (was: )

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type.png, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

HBelusca (JIRA)

2017-04-25 01:54:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92262#comment-92262 ]

HBelusca commented on CORE-12906:
---------------------------------

That looks great! Just a layout improvement, I think, for [^edit-file-type.png]: it would be great IMO to have the "Change Icon..." button having the same width (and height too) as the other "New", "Edit", ... buttons, and then, have the right-side of the extension display name edit field being vertically-aligned with the right-side of the "Actions" list. :)

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type.png, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

HBelusca (JIRA)

2017-04-25 01:55:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92262#comment-92262 ]

HBelusca edited comment on CORE-12906 at 4/25/17 1:54 AM:
----------------------------------------------------------

That looks great! Just a layout improvement, I think, for [^edit-file-type.png]: it would be great IMO to have the "Change Icon..." button having the same width (and height too) as the other "New", "Edit", ... buttons, and then, have the right-side of the extension display name edit field being vertically-aligned with the right-side of the "Actions" list. :)

EDIT: And for [^new-ext-dialog.png], having the right-side of the "Advanced" button be vertically aligned with the right-sides of the combobox and the "Cancel" button too ;)

was (Author: hbelusca):
That looks great! Just a layout improvement, I think, for [^edit-file-type.png]: it would be great IMO to have the "Change Icon..." button having the same width (and height too) as the other "New", "Edit", ... buttons, and then, have the right-side of the extension display name edit field being vertically-aligned with the right-side of the "Actions" list. :)

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type.png, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-04-25 03:03:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92263#comment-92263 ]

Katayama Hirofumi MZ commented on CORE-12906:
---------------------------------------------

There is duplication of dialog resource IDs:

{{#define IDD_EDIT_FILE_TYPE 29}}

{{#define IDD_SHUTDOWN 29}}

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type.png, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

dsp8195 (JIRA)

2017-04-25 03:57:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92264#comment-92264 ]

dsp8195 commented on CORE-12906:
--------------------------------

I would suggest to merge those two dialogues together (i.e. new file extension and file type editor). This would help to:
# Change the extension into a new one with preservation of the actions associated with it (or make a copy of the extension, with the same results).
# Get rid of the situation when the smaller dialogue is hidden behind the large "advanced" one.

Another suggestion is addition of the "Unique icon for each file" checkbox, which would gray out the "Change icon..." button and put "%1" parameter as a source for the file's icon. This would allow to generate icons which contain a tiny thumbnail of the image files, or read the icon resources from the executable files.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type.png, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-04-25 04:00:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Katayama Hirofumi MZ updated CORE-12906:
----------------------------------------
Attachment: file-type-dialog-v3.patch
edit-file-type-v3.png
new-ext-dialog-v3.png

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

dsp8195 (JIRA)

2017-04-25 04:02:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92264#comment-92264 ]

dsp8195 edited comment on CORE-12906 at 4/25/17 4:01 AM:
---------------------------------------------------------

I would suggest to add an option to be able to change or copy the file extension with preservation of the file type and associated actions.

Another suggestion is addition of the "Unique icon for each file" checkbox, which would gray out the "Change icon..." button and put "%1" parameter as a source for the file's icon. This would allow to generate icons which contain a tiny thumbnail of the image files, or read the icon resources from the executable files.

was (Author: dsp8195):
I would suggest to merge those two dialogues together (i.e. new file extension and file type editor). This would help to:
# Change the extension into a new one with preservation of the actions associated with it (or make a copy of the extension, with the same results).
# Get rid of the situation when the smaller dialogue is hidden behind the large "advanced" one.

Another suggestion is addition of the "Unique icon for each file" checkbox, which would gray out the "Change icon..." button and put "%1" parameter as a source for the file's icon. This would allow to generate icons which contain a tiny thumbnail of the image files, or read the icon resources from the executable files.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-04-25 04:04:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92265#comment-92265 ]

Katayama Hirofumi MZ commented on CORE-12906:
---------------------------------------------

[^file-type-dialog-v3.patch]
[^edit-file-type-v3.png]
[^new-ext-dialog-v3.png]
New Patch! Fixed what [~HBelusca] said.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-04-25 06:25:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92263#comment-92263 ]

Katayama Hirofumi MZ edited comment on CORE-12906 at 4/25/17 6:24 AM:
----------------------------------------------------------------------

There is duplication of dialog resource IDs:
{{#define IDD_EDIT_FILE_TYPE 29}}
{{#define IDD_SHUTDOWN 29}}
{color:#d04437}EDIT: Fixed.{color}

was (Author: katayama_hirofumi_mz):
There is duplication of dialog resource IDs:

{{#define IDD_EDIT_FILE_TYPE 29}}

{{#define IDD_SHUTDOWN 29}}

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Giannis Adamopoulos (JIRA)

2017-04-25 07:37:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92267#comment-92267 ]

Giannis Adamopoulos commented on CORE-12906:
--------------------------------------------

Your LoadStringDx is broken, it should get a buffer to fill in. returning a pointer to the stack is just wrong.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Giannis Adamopoulos (JIRA)

2017-04-25 07:37:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92267#comment-92267 ]

Giannis Adamopoulos edited comment on CORE-12906 at 4/25/17 7:36 AM:
---------------------------------------------------------------------

Your LoadStringDx is broken, it should get a buffer to fill in. returning a pointer to the stack is just wrong. But I generally I like the idea of a function that either reads a string or sets a default value.

was (Author: smiley):
Your LoadStringDx is broken, it should get a buffer to fill in. returning a pointer to the stack is just wrong.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-04-25 07:40:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92268#comment-92268 ]

Katayama Hirofumi MZ commented on CORE-12906:
---------------------------------------------

Look carefully. That variable is 'static'.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Mark Jansen (JIRA)

2017-04-25 08:00:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92270#comment-92270 ]

Mark Jansen commented on CORE-12906:
------------------------------------

This is a .cpp file, why not use CString to load the string?

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-04-25 08:33:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92271#comment-92271 ]

Katayama Hirofumi MZ commented on CORE-12906:
---------------------------------------------

I agree with Jansen. Providing default values is nonsense.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-04-25 10:23:00 UTC

Permalink

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-04-25 10:24:01 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92273#comment-92273 ]

Katayama Hirofumi MZ commented on CORE-12906:
---------------------------------------------

[^file-type-dialog-v4.patch]
Used CStringW.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-04-25 10:47:00 UTC

Permalink

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-04-25 10:48:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92275#comment-92275 ]

Katayama Hirofumi MZ commented on CORE-12906:
---------------------------------------------

[^file-type-dialog-v5.patch]
Human readable comments added.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Mark Jansen (JIRA)

2017-04-25 11:42:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92277#comment-92277 ]

Mark Jansen commented on CORE-12906:
------------------------------------

looks good from looking over it.

A small note:

{code}
col.pszText = strExtensions.GetBuffer();
{code}
You don't need to use GetBuffer() there, just assigning (casting) the CString to WCHAR* should give a pointer to the string,
that is valid as long as the object is not destructed.
This saves you from having to release the buffer later on.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-04-25 11:59:00 UTC

Permalink

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-04-25 12:00:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92279#comment-92279 ]

Katayama Hirofumi MZ commented on CORE-12906:
---------------------------------------------

[^file-type-dialog-v6.patch]
Two casts for single assignment required.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

HBelusca (JIRA)

2017-04-25 13:33:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92287#comment-92287 ]

HBelusca commented on CORE-12906:
---------------------------------

[~katayama_hirofumi_mz]: No need to give a "-version-X" to your patches: Jira can automatically detect which one is the newest of all, and would gray out the older patches.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

manuel (JIRA)

2017-04-25 19:21:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=92299#comment-92299 ]

manuel commented on CORE-12906:
-------------------------------

Nice work [~katayama_hirofumi_mz] (y)

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Thomas Faber (JIRA)

2017-04-26 07:29:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Faber updated CORE-12906:
--------------------------------
Status: Open (was: Untriaged)

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Thomas Faber (JIRA)

2017-04-26 08:14:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Faber updated CORE-12906:
--------------------------------
Sprint: April 2017

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Colin Finck (JIRA)

2017-05-03 15:10:08 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Finck updated CORE-12906:
-------------------------------
Sprint: April 2017, May 2017 (was: April 2017)

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Thomas Faber (JIRA)

2017-05-18 12:01:06 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93514#comment-93514 ]

Thomas Faber commented on CORE-12906:
-------------------------------------

[~katayama_hirofumi_mz] I've started to review the patch but it's not easy due to its size and the mix of unrelated changes. Could you please remove unnecessary changes such as code formatting and converting to CStringW? The latter would be good as a separate patch, the former just doesn't need to happen.
Thanks.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Thomas Faber (JIRA)

2017-05-18 12:16:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93515#comment-93515 ]

Thomas Faber commented on CORE-12906:
-------------------------------------

Some thoughts:
* MyRegDeleteTreeW should go into vista.c as RegDeleteTreeW
* The control ids should be added as IDC_ constants to shresdef.h
* {{s_hListView = s_hListView;}} is a typo
* So is {{s_pItem = s_pItem;}}

Thanks.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-05-18 13:09:00 UTC

Permalink

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, file-type-dialog-v7.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-05-18 13:10:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93518#comment-93518 ]

Katayama Hirofumi MZ commented on CORE-12906:
---------------------------------------------

[^file-type-dialog-v7.patch]
minimal change.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, file-type-dialog-v7.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Colin Finck (JIRA)

2017-06-01 08:53:06 UTC

Permalink

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, file-type-dialog-v7.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-07-08 11:45:01 UTC

Permalink

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, file-type-dialog-v7.patch, file-type-dialog-v8.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-07-08 11:45:03 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Katayama Hirofumi MZ updated CORE-12906:
----------------------------------------
Comment: was deleted

(was: [^file-type-dialog-v7.patch]
minimal change.)

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, file-type-dialog-v7.patch, file-type-dialog-v8.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-07-08 12:27:01 UTC

Permalink

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, file-type-dialog-v7.patch, file-type-dialog-v8.patch, file-type-dialog-v9.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-07-08 12:28:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=95341#comment-95341 ]

Katayama Hirofumi MZ commented on CORE-12906:
---------------------------------------------

[^file-type-dialog-v9.patch]
I did it.

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, file-type-dialog-v7.patch, file-type-dialog-v8.patch, file-type-dialog-v9.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2017-09-22 07:40:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=97432#comment-97432 ]

Katayama Hirofumi MZ commented on CORE-12906:
---------------------------------------------

Looking at [^edit-file-type.png], icons are wrong and mismatched with file types. Why wrong?

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, file-type-dialog-v7.patch, file-type-dialog-v8.patch, file-type-dialog-v9.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Robert Naumann (JIRA)

2018-01-22 22:10:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=101265#comment-101265 ]

Robert Naumann commented on CORE-12906:
---------------------------------------

What about a PR?

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, file-type-dialog-v7.patch, file-type-dialog-v8.patch, file-type-dialog-v9.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2018-01-23 05:39:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=101273#comment-101273 ]

Katayama Hirofumi MZ commented on CORE-12906:
---------------------------------------------

https://github.com/reactos/reactos/pull/316

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, file-type-dialog-v7.patch, file-type-dialog-v8.patch, file-type-dialog-v9.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Petr Akhlamov (JIRA)

2018-01-24 22:15:00 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=101315#comment-101315 ]

Petr Akhlamov commented on CORE-12906:
--------------------------------------

CORE-1246 - duplicate?

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, file-type-dialog-v7.patch, file-type-dialog-v8.patch, file-type-dialog-v9.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2018-05-12 13:15:03 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103972#comment-103972 ]

Katayama Hirofumi MZ commented on CORE-12906:
---------------------------------------------

https://github.com/reactos/reactos/pull/544

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, file-type-dialog-v7.patch, file-type-dialog-v8.patch, file-type-dialog-v9.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

Katayama Hirofumi MZ (JIRA)

2018-05-12 11:13:01 UTC

Permalink

[ https://jira.reactos.org/browse/CORE-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103968#comment-103968 ]

Katayama Hirofumi MZ commented on CORE-12906:
---------------------------------------------

https://github.com/reactos/reactos/pull/543

Folder Options: File Types: Implement
-------------------------------------
Key: CORE-12906
URL: https://jira.reactos.org/browse/CORE-12906
Project: Core ReactOS
Issue Type: New Feature
Components: Shell
Reporter: Katayama Hirofumi MZ
Assignee: Bug Zilla
Labels: PATCH
Attachments: edit-file-type-v3.png, edit-file-type.png, file-type-dialog-v3.patch, file-type-dialog-v4.patch, file-type-dialog-v5.patch, file-type-dialog-v6.patch, file-type-dialog-v7.patch, file-type-dialog-v8.patch, file-type-dialog-v9.patch, folderopts-file-type-dialog-retry.patch, folderopts-file-type-dialog.patch, new-ext-dialog-v3.png, new-ext-dialog.png
[^folderopts-file-type-dialog.patch]
This patch improves Folder Options dialog.
* Improved Folder Options codes.
* Added LoadStringDx function.
* Added Dialog IDD_NEW_EXT "Create New Extension" and Dialog IDD_EDIT_FILE_TYPE "Edit File Type".
* Added "New", "Delete" and "Advanced" actions.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)