[ros-bugs] [jira] (CORE-12752) Photoshop CS2 regressed due to baseaddress conflicts

[Colin Finck (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93712#comment-93712 ]

Colin Finck commented on CORE-12752:
------------------------------------

Problem still persists in r74613, but it's different in GCC and MSVC.
While Photoshop doesn't start at all in the GCC build with the aforementioned error message, it starts up but then BSODs in win32k.sys in the MSVC build. Logs are attached.

Photoshop CS2 regressed due to baseaddress conflicts
----------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Colin Finck (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Finck updated CORE-12752:
-------------------------------
Attachment: pscs2_r74613_msvc.txt

Photoshop CS2 regressed due to baseaddress conflicts
----------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Colin Finck (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Finck updated CORE-12752:
-------------------------------
Summary: Photoshop CS2 doesn't start in recent trunk builds (was: Photoshop CS2 regressed due to baseaddress conflicts)

Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Colin Finck (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Finck updated CORE-12752:
-------------------------------
Attachment: pscs2_r74613_gcc.txt

Photoshop CS2 regressed due to baseaddress conflicts
----------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Mark Jansen (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93717#comment-93717 ]

Mark Jansen commented on CORE-12752:
------------------------------------

Maybe we should relocate {{MSVCP71.dll}} (or any dll) that overlaps certain system dlls?

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Mark Jansen (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93726#comment-93726 ]

Mark Jansen edited comment on CORE-12752 at 5/22/17 12:16 PM:
--------------------------------------------------------------

Tests on windows show that user32.dll can be relocated.
why can't we?

Testcase:
Step 1: capture user32.dll address (using f.e. LordPE)
Step 2: compile a dll at this base address
Step 3: make an application load your dll before user32.



was (Author: learn_more):
Tests on windows show that user32.dll can be relocated.
why can't we?

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Mark Jansen (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93726#comment-93726 ]

Mark Jansen commented on CORE-12752:
------------------------------------

Tests on windows show that user32.dll can be relocated.
why can't we?

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Mark Jansen (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Jansen updated CORE-12752:
-------------------------------
Attachment: testcase.zip

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Mark Jansen (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93717#comment-93717 ]

Mark Jansen edited comment on CORE-12752 at 5/22/17 11:08 AM:
--------------------------------------------------------------

Maybe we should relocate {{MSVCP71.dll}} (or any dll) that overlaps certain system dlls?

also, if you use 'kp' instead of 'k', that should include arguments.


was (Author: learn_more):
Maybe we should relocate {{MSVCP71.dll}} (or any dll) that overlaps certain system dlls?

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[HBelusca (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93736#comment-93736 ]

HBelusca commented on CORE-12752:
---------------------------------

[~learn_more]: The "Illegal System DLL Relocation. The system DLL user32.dll was relocated in memory.
The application will not run properly. The relocation occurred because the DLL
C:\WINDOWS\system32\foobar.dll occupied an address range reserved for Windows system DLLs. The
vendor supplying the DLL should be contacted for a new DLL."
actually exists on Windows, so maybe Windows is able to relocate user32.dll, but I guess it'll show the message even with your test ?

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Mark Jansen (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93737#comment-93737 ]

Mark Jansen commented on CORE-12752:
------------------------------------

I only tested on x64 win10, where it does not show any message at all.
I'll test on 2k3 tonight.

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Mark Jansen (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93753#comment-93753 ]

Mark Jansen commented on CORE-12752:
------------------------------------

If i manually load user32 with LoadLibrary, it does indeed display this error on 2k3
If i add user32 to the imports (by calling MessageBeep), then it relocates my dll.
However, i see that the entry for user32 is in the iat before the entry for my dll, so this might be an accident.
I'll see if i can reverse the iat order

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Mark Jansen (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93754#comment-93754 ]

Mark Jansen commented on CORE-12752:
------------------------------------

Ok.

2k3 cannot handle this properly, newer windows can.

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Colin Finck (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Finck updated CORE-12752:
-------------------------------
Attachment: pscs2_r74622_msvc_stacktrace_with_args.txt

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Colin Finck (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93757#comment-93757 ]

Colin Finck commented on CORE-12752:
------------------------------------

For the bug in MSVC builds, I have attached "pscs2_r74622_msvc_stacktrace_with_args.txt", which gives a stacktrace with arguments of the same win32k crash as in "pscs2_r74613_msvc.txt".

The user32 relocation bug in GCC builds is also a candidate for regress-testing. The range is quite large though: I only recall that Photoshop CS2 worked when we shortly tried it on ReactOS during FOSDEM in February 2014.

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Mark Jansen (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93759#comment-93759 ]

Mark Jansen commented on CORE-12752:
------------------------------------

I think we need to debug the process to actually capture this exception.
Exit code will be {{ERROR_WAIT_NO_CHILDREN}} if it crashes (on 2k3 f.e.)

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Mark Jansen (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93759#comment-93759 ]

Mark Jansen edited comment on CORE-12752 at 5/22/17 10:35 PM:
--------------------------------------------------------------

I think we need to debug the process to actually capture this exception.
Exit code will be {{ERROR_WAIT_NO_CHILDREN}} if it crashes (on 2k3 f.e.)
talking about base address clash.


was (Author: learn_more):
I think we need to debug the process to actually capture this exception.
Exit code will be {{ERROR_WAIT_NO_CHILDREN}} if it crashes (on 2k3 f.e.)

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Mark Jansen (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Jansen updated CORE-12752:
-------------------------------
Attachment: LdrRelocateImage.c

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Giannis Adamopoulos (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93767#comment-93767 ]

Giannis Adamopoulos commented on CORE-12752:
--------------------------------------------

The MSVC bug is really weird. It crashes because RtlStringCbCopyW get a bad pointer but I can't find where this pointer comes from. It seems that FontFamilyFillInfo gets it as its 3rd parameter however GetFontFamilyInfoForList passes NULL for this parameter.

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Giannis Adamopoulos (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93767#comment-93767 ]

Giannis Adamopoulos edited comment on CORE-12752 at 5/23/17 7:33 AM:
---------------------------------------------------------------------

The MSVC bug is really weird. It crashes because RtlStringCbCopyW get a bad pointer but I can't find where this pointer comes from. It seems that FontFamilyFillInfo gets it as its 3rd parameter however GetFontFamilyInfoForList passes NULL for this parameter. Perhaps the value that can't be copied is the pointer in Otm?


was (Author: smiley):
The MSVC bug is really weird. It crashes because RtlStringCbCopyW get a bad pointer but I can't find where this pointer comes from. It seems that FontFamilyFillInfo gets it as its 3rd parameter however GetFontFamilyInfoForList passes NULL for this parameter.

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Mark Jansen (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93768#comment-93768 ]

Mark Jansen commented on CORE-12752:
------------------------------------

Probably the same as CORE-13089, however since it does not want to install for some reason (clicked all buttons that are enabled)....

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Giannis Adamopoulos (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93772#comment-93772 ]

Giannis Adamopoulos commented on CORE-12752:
--------------------------------------------

Please retest with 74633.

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Colin Finck (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=93776#comment-93776 ]

Colin Finck commented on CORE-12752:
------------------------------------

Confirmed, r74633 fixes the issue in MSVC builds. Thanks!
So the user32 relocation in GCC builds is the only thing that's left.

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Mark Jansen (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=102134#comment-102134 ]

Mark Jansen commented on CORE-12752:
------------------------------------

There are some reserved fields in {{SharedUserData}} (Type: {{KUSER_SHARED_DATA}}).
We could store the user32 load address and size, or use the size from one of the baseaddress cmake files.

Then, when loading the module (f.e. in {{MmMapViewOfSection}} we could check if this is not user32, and we are inside the user32 address space, and relocate the dll.

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Attachments: LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[reactosfanboy (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

reactosfanboy updated CORE-12752:
---------------------------------
Attachment: 2ndStageBSOD_afterRelocationOfUser32.log

*Warning:* setting the base-address of user32.dll to 0x77380000 *without changing anything else* will invoke a relocation of user32.dll due to conflicting kernel32_vista.dll and this will lead to 2nd stage BSOD like in [^2ndStageBSOD_afterRelocationOfUser32.log].
So if we want to use same address as 2k3sp2, we'd need to move others away definitely!

[CMAKE] gcc base address - Photoshop CS2 doesn't start in recent trunk builds
-----------------------------------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Labels: REGRESSION
Attachments: 2ndStageBSOD_afterRelocationOfUser32.log, CORE-12752-MoveItWithOutThinkingTwice.patch, CORE-12752_gcc_USER32reloc-regressionTest.txt, LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Mark Jansen (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103982#comment-103982 ]

Mark Jansen commented on CORE-12752:
------------------------------------

User32 from my 2k3 vm is at {{0x77380000}}

[CMAKE] gcc base address - Photoshop CS2 doesn't start in recent trunk builds
-----------------------------------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Labels: REGRESSION
Attachments: CORE-12752-MoveItWithOutThinkingTwice.patch, CORE-12752_gcc_USER32reloc-regressionTest.txt, LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[reactosfanboy (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103980#comment-103980 ]

reactosfanboy commented on CORE-12752:
--------------------------------------

Oopsie! That patch is even worse than I thought at first glance: the addresses are in *des*cending order (which means I created a collision even with our dlls). :D

[CMAKE] gcc base address - Photoshop CS2 doesn't start in recent trunk builds
-----------------------------------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Labels: REGRESSION
Attachments: CORE-12752-MoveItWithOutThinkingTwice.patch, CORE-12752_gcc_USER32reloc-regressionTest.txt, LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[reactosfanboy (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

reactosfanboy updated CORE-12752:
---------------------------------
Attachment: (was: CORE-12752_gcc_USER32reloc-regressionTest.txt)

[CMAKE] gcc base address - Photoshop CS2 doesn't start in recent trunk builds
-----------------------------------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Labels: REGRESSION
Attachments: CORE-12752-MoveItWithOutThinkingTwice.patch, CORE-12752_gcc_USER32reloc-regressionTest.txt, LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[reactosfanboy (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103977#comment-103977 ]

reactosfanboy commented on CORE-12752:
--------------------------------------

I double-checked: [^CORE-12752-MoveItWithOutThinkingTwice.patch] does fix the issue for me, but I have no clue, whether it will cause different trouble in the future. Do I violate any reserved areas with this patch?
Am I allowed to commit that or is there any better way to handle that [~ThFabba]?

[CMAKE] gcc base address - Photoshop CS2 doesn't start in recent trunk builds
-----------------------------------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Labels: REGRESSION
Attachments: CORE-12752-MoveItWithOutThinkingTwice.patch, CORE-12752_gcc_USER32reloc-regressionTest.txt, CORE-12752_gcc_USER32reloc-regressionTest.txt, LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[reactosfanboy (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

reactosfanboy updated CORE-12752:
---------------------------------
Attachment: CORE-12752-MoveItWithOutThinkingTwice.patch

[CMAKE] gcc base address - Photoshop CS2 doesn't start in recent trunk builds
-----------------------------------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Labels: REGRESSION
Attachments: CORE-12752-MoveItWithOutThinkingTwice.patch, CORE-12752_gcc_USER32reloc-regressionTest.txt, CORE-12752_gcc_USER32reloc-regressionTest.txt, LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[reactosfanboy (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

reactosfanboy updated CORE-12752:
---------------------------------
Summary: [CMAKE] gcc base address - Photoshop CS2 doesn't start in recent trunk builds (was: Photoshop CS2 doesn't start in recent trunk builds)
Module: cmake

[CMAKE] gcc base address - Photoshop CS2 doesn't start in recent trunk builds
-----------------------------------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Labels: REGRESSION
Attachments: CORE-12752_gcc_USER32reloc-regressionTest.txt, CORE-12752_gcc_USER32reloc-regressionTest.txt, LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[reactosfanboy (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

reactosfanboy updated CORE-12752:
---------------------------------
Guilty Revision: 68838
Guilty Commit: a9a2119c0c38a4c7da6093a9826ee3f264523ad9
Attachment: CORE-12752_gcc_USER32reloc-regressionTest.txt

Ok, no surprises here. We broke that with changing the base addresses in SVN r68838 == git commit [a9a2119c0c38a4c7da6093a9826ee3f264523ad9|https://git.reactos.org/?p=reactos.git;a=commit;h=a9a2119c0c38a4c7da6093a9826ee3f264523ad9]
Is there a better way to find a good base-address beside "trial-and-error"?
[~AmineKhaldi] what's your date of birth again expressed in hex? ;-)

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Labels: REGRESSION
Attachments: CORE-12752_gcc_USER32reloc-regressionTest.txt, CORE-12752_gcc_USER32reloc-regressionTest.txt, LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[reactosfanboy (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

reactosfanboy updated CORE-12752:
---------------------------------
Labels: REGRESSION (was: )
Attachment: CORE-12752_gcc_USER32reloc-regressionTest.txt

There is an *ancient* guilty / unhiding rev. I will hunt it in the hope it will help us.
[^CORE-12752_gcc_USER32reloc-regressionTest.txt] in progress...

Post by Colin Finck (JIRA)
Photoshop CS2 doesn't start in recent trunk builds
--------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Labels: REGRESSION
Attachments: CORE-12752_gcc_USER32reloc-regressionTest.txt, LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[HBelusca (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103993#comment-103993 ]

HBelusca commented on CORE-12752:
---------------------------------

Shouldn't the dlls that are loaded late (like kernel32_vista I suppose??) be relocated when they might overlap dlls that are loaded sooner (like user32, which should actually be already loaded if being part of the KnownDlls) ?

[CMAKE] gcc base address - Photoshop CS2 doesn't start in recent trunk builds
-----------------------------------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Labels: REGRESSION
Attachments: 2ndStageBSOD_afterRelocationOfUser32.log, CORE-12752-MoveItWithOutThinkingTwice.patch, CORE-12752_gcc_USER32reloc-regressionTest.txt, LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Mark Jansen (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103994#comment-103994 ]

Mark Jansen commented on CORE-12752:
------------------------------------

In this case, user32 is loaded after kernel32_vista, so it goes boom.

[CMAKE] gcc base address - Photoshop CS2 doesn't start in recent trunk builds
-----------------------------------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Labels: REGRESSION
Attachments: 2ndStageBSOD_afterRelocationOfUser32.log, CORE-12752-MoveItWithOutThinkingTwice.patch, CORE-12752_gcc_USER32reloc-regressionTest.txt, LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[reactosfanboy (JIRA)]

[ https://jira.reactos.org/browse/CORE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103996#comment-103996 ]

reactosfanboy commented on CORE-12752:
--------------------------------------

Btw kernel32_vista is not delay-loaded yet, remember CORE-13602 is blocked by CORE-6504 *for gcc*. I agree with what [~learn_more] said.

[CMAKE] gcc base address - Photoshop CS2 doesn't start in recent trunk builds
-----------------------------------------------------------------------------
Key: CORE-12752
URL: https://jira.reactos.org/browse/CORE-12752
Project: Core ReactOS
Issue Type: Bug
Reporter: Colin Finck
Assignee: Bug Zilla
Labels: REGRESSION
Attachments: 2ndStageBSOD_afterRelocationOfUser32.log, CORE-12752-MoveItWithOutThinkingTwice.patch, CORE-12752_gcc_USER32reloc-regressionTest.txt, LdrRelocateImage.c, pscs2_r74613_gcc.txt, pscs2_r74613_msvc.txt, pscs2_r74622_msvc_stacktrace_with_args.txt, testcase.zip
The system DLL user32.dll was relocated in memory. The application will not run properly.
The relocation occurred because the DLL C:\Program Files\Adobe\Adobe Photoshop CS2\MSVCP71.dll occupied an address range reserved for ReactOS system DLLs. The vendor supplying the DLL should be contacted for a new DLL.

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)