Oleg Dubinskiy (JIRA)
2018-05-13 08:24:00 UTC
[ https://jira.reactos.org/browse/CORE-14619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103987#comment-103987 ]
Oleg Dubinskiy edited comment on CORE-14619 at 5/13/18 8:23 AM:
----------------------------------------------------------------
[~reactosfanboy], no, removing that line didn't help. On the contrary, after this, the teming is missing for some elements like Start Button and the buttons and checkboxes in the windows. Also the theme preview in the second stage setup regressed. See attached screenshots.
The reproduction steps are very simple:
for the squared checkboxes: right click on the taskbar -> "Properties";
for the circled checkboxes: right ckick on My Computer -> "Properties" -> go to the "Computer Name" tab -> and click on "Change" button.
There are clickable checkboxes which can help you to test this regression.
was (Author: oleg dubinskij):
[~reactosfanboy], no, removing that line didn't help. On the contrary, after this, the teming is missing for some elements like Start Button and the buttons and checkboxes in the windows. Also the theme preview in the second stage seup regressed. See attached screenshots.
The reproduction steps are very simple:
for the squared checkboxes: right click on the taskbar -> "Properties";
for the circled checkboxes: right ckick on My Computer -> "Properties" -> go to the "Computer Name" tab -> and click on "Change" button.
There are clickable checkboxes which can help you to test this regression.
This message was sent by Atlassian JIRA
(v7.3.2#73013)
Oleg Dubinskiy edited comment on CORE-14619 at 5/13/18 8:23 AM:
----------------------------------------------------------------
[~reactosfanboy], no, removing that line didn't help. On the contrary, after this, the teming is missing for some elements like Start Button and the buttons and checkboxes in the windows. Also the theme preview in the second stage setup regressed. See attached screenshots.
The reproduction steps are very simple:
for the squared checkboxes: right click on the taskbar -> "Properties";
for the circled checkboxes: right ckick on My Computer -> "Properties" -> go to the "Computer Name" tab -> and click on "Change" button.
There are clickable checkboxes which can help you to test this regression.
was (Author: oleg dubinskij):
[~reactosfanboy], no, removing that line didn't help. On the contrary, after this, the teming is missing for some elements like Start Button and the buttons and checkboxes in the windows. Also the theme preview in the second stage seup regressed. See attached screenshots.
The reproduction steps are very simple:
for the squared checkboxes: right click on the taskbar -> "Properties";
for the circled checkboxes: right ckick on My Computer -> "Properties" -> go to the "Computer Name" tab -> and click on "Change" button.
There are clickable checkboxes which can help you to test this regression.
Checkbox buttons theming regression
-----------------------------------
Key: CORE-14619
URL: https://jira.reactos.org/browse/CORE-14619
Project: Core ReactOS
Issue Type: Bug
Components: Wine
Reporter: Oleg Dubinskiy
Assignee: Bug Zilla
Labels: REGRESSION, THEMES
Attachments: comparison 1.png, comparison 2.png, non-themed 1.png, non-themed 2.png, non-themed 3.png, non-thmed 4.png, theme preview 1.png, theme preview 2.png
This regression appears if try to check/uncheck squared and circled checkbox buttons. There is incorrect theming when direct mouse cursor on the button and click on it. This problem is actual for any theme, include Lautus, but except Classic theme. It's present since 0.4.9-dev-719. In 718 theming is correct. The difference is visible on comparison images. For example I used Luna and Lautus themes.
-------------------------------------
Key: CORE-14619
URL: https://jira.reactos.org/browse/CORE-14619
Project: Core ReactOS
Issue Type: Bug
Components: Wine
Reporter: Oleg Dubinskiy
Assignee: Bug Zilla
Labels: REGRESSION, THEMES
Attachments: comparison 1.png, comparison 2.png, non-themed 1.png, non-themed 2.png, non-themed 3.png, non-thmed 4.png, theme preview 1.png, theme preview 2.png
This regression appears if try to check/uncheck squared and circled checkbox buttons. There is incorrect theming when direct mouse cursor on the button and click on it. This problem is actual for any theme, include Lautus, but except Classic theme. It's present since 0.4.9-dev-719. In 718 theming is correct. The difference is visible on comparison images. For example I used Luna and Lautus themes.
This message was sent by Atlassian JIRA
(v7.3.2#73013)