[ros-bugs] [jira] (CORE-14619) Checkbox buttons theming regression

[Oleg Dubinskiy (JIRA)]

[ https://jira.reactos.org/browse/CORE-14619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103987#comment-103987 ]

Oleg Dubinskiy edited comment on CORE-14619 at 5/13/18 8:23 AM:
----------------------------------------------------------------

[~reactosfanboy], no, removing that line didn't help. On the contrary, after this, the teming is missing for some elements like Start Button and the buttons and checkboxes in the windows. Also the theme preview in the second stage setup regressed. See attached screenshots.

The reproduction steps are very simple:
for the squared checkboxes: right click on the taskbar -> "Properties";
for the circled checkboxes: right ckick on My Computer -> "Properties" -> go to the "Computer Name" tab -> and click on "Change" button.
There are clickable checkboxes which can help you to test this regression.


was (Author: oleg dubinskij):
[~reactosfanboy], no, removing that line didn't help. On the contrary, after this, the teming is missing for some elements like Start Button and the buttons and checkboxes in the windows. Also the theme preview in the second stage seup regressed. See attached screenshots.

The reproduction steps are very simple:
for the squared checkboxes: right click on the taskbar -> "Properties";
for the circled checkboxes: right ckick on My Computer -> "Properties" -> go to the "Computer Name" tab -> and click on "Change" button.
There are clickable checkboxes which can help you to test this regression.

Checkbox buttons theming regression
-----------------------------------
Key: CORE-14619
URL: https://jira.reactos.org/browse/CORE-14619
Project: Core ReactOS
Issue Type: Bug
Components: Wine
Reporter: Oleg Dubinskiy
Assignee: Bug Zilla
Labels: REGRESSION, THEMES
Attachments: comparison 1.png, comparison 2.png, non-themed 1.png, non-themed 2.png, non-themed 3.png, non-thmed 4.png, theme preview 1.png, theme preview 2.png
This regression appears if try to check/uncheck squared and circled checkbox buttons. There is incorrect theming when direct mouse cursor on the button and click on it. This problem is actual for any theme, include Lautus, but except Classic theme. It's present since 0.4.9-dev-719. In 718 theming is correct. The difference is visible on comparison images. For example I used Luna and Lautus themes.

...

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Oleg Dubinskiy (JIRA)]

[ https://jira.reactos.org/browse/CORE-14619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103987#comment-103987 ]

Oleg Dubinskiy commented on CORE-14619:
---------------------------------------

[~reactosfanboy], no, removing that line didn't help. On the contrary, after this, the teming is missing for some elements like Start Button and the buttons and checkboxes in the windows. Also the theme preview in the second stage seup regressed. See attached screenshots.

The reproduction steps are very simple:
for the squared checkboxes: right click on the taskbar -> "Properties";
for the circled checkboxes: right ckick on My Computer -> "Properties" -> go to the "Computer Name" tab -> and click on "Change" button.
There are clickable checkboxes which can help you to test this regression.

Checkbox buttons theming regression
-----------------------------------
Key: CORE-14619
URL: https://jira.reactos.org/browse/CORE-14619
Project: Core ReactOS
Issue Type: Bug
Components: Wine
Reporter: Oleg Dubinskiy
Assignee: Bug Zilla
Labels: REGRESSION, THEMES
Attachments: comparison 1.png, comparison 2.png, non-themed 1.png, non-themed 2.png, non-themed 3.png, non-thmed 4.png, theme preview 1.png, theme preview 2.png
This regression appears if try to check/uncheck squared and circled checkbox buttons. There is incorrect theming when direct mouse cursor on the button and click on it. This problem is actual for any theme, include Lautus, but except Classic theme. It's present since 0.4.9-dev-719. In 718 theming is correct. The difference is visible on comparison images. For example I used Luna and Lautus themes.

...

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Oleg Dubinskiy (JIRA)]

[ https://jira.reactos.org/browse/CORE-14619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Dubinskiy updated CORE-14619:
----------------------------------
Attachment: non-themed 1.png
non-themed 2.png
non-themed 3.png
non-thmed 4.png
theme preview 1.png
theme preview 2.png

Checkbox buttons theming regression
-----------------------------------
Key: CORE-14619
URL: https://jira.reactos.org/browse/CORE-14619
Project: Core ReactOS
Issue Type: Bug
Components: Wine
Reporter: Oleg Dubinskiy
Assignee: Bug Zilla
Labels: REGRESSION, THEMES
Attachments: comparison 1.png, comparison 2.png, non-themed 1.png, non-themed 2.png, non-themed 3.png, non-thmed 4.png, theme preview 1.png, theme preview 2.png
This regression appears if try to check/uncheck squared and circled checkbox buttons. There is incorrect theming when direct mouse cursor on the button and click on it. This problem is actual for any theme, include Lautus, but except Classic theme. It's present since 0.4.9-dev-719. In 718 theming is correct. The difference is visible on comparison images. For example I used Luna and Lautus themes.

...

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[reactosfanboy (JIRA)]

[ https://jira.reactos.org/browse/CORE-14619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103984#comment-103984 ]

reactosfanboy commented on CORE-14619:
--------------------------------------

That's no proper solution, but is still interesting for me [~Oleg Dubinskij]:
Does the regression vanish if you remove the line "<windowClass>Button</windowClass>" from x86_microsoft.windows.common-controls_6595b64144ccf1df_6.0.2600.2982_none_deadbeef.manifest
and rebuild ros?

Beside that: Can you please provide some easy reproduction steps (where such a squared or circled checkbox can be found in ros for example)?
 

Checkbox buttons theming regression
-----------------------------------
Key: CORE-14619
URL: https://jira.reactos.org/browse/CORE-14619
Project: Core ReactOS
Issue Type: Bug
Components: Wine
Reporter: Oleg Dubinskiy
Assignee: Bug Zilla
Labels: REGRESSION, THEMES
Attachments: comparison 1.png, comparison 2.png
This regression appears if try to check/uncheck squared and circled checkbox buttons. There is incorrect theming when direct mouse cursor on the button and click on it. This problem is actual for any theme, include Lautus, but except Classic theme. It's present since 0.4.9-dev-719. In 718 theming is correct. The difference is visible on comparison images. For example I used Luna and Lautus themes.

...

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[reactosfanboy (JIRA)]

[ https://jira.reactos.org/browse/CORE-14619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103983#comment-103983 ]

reactosfanboy edited comment on CORE-14619 at 5/12/18 7:56 PM:
---------------------------------------------------------------

[b3fb8555bf9abcc04eeac31c7153d33e2f027fc0|https://git.reactos.org/?p=reactos.git;a=commit;h=b3fb8555bf9abcc04eeac31c7153d33e2f027fc0]
[COMCTL32] Sync with Wine Staging 3.3. CORE-14434
cc [~AmineKhaldi]


was (Author: reactosfanboy):
[b3fb8555bf9abcc04eeac31c7153d33e2f027fc0|https://git.reactos.org/?p=reactos.git;a=commit;h=b3fb8555bf9abcc04eeac31c7153d33e2f027fc0]
[COMCTL32] Sync with Wine Staging 3.3. CORE-14434
cc [~akhaldi]

Checkbox buttons theming regression
-----------------------------------
Key: CORE-14619
URL: https://jira.reactos.org/browse/CORE-14619
Project: Core ReactOS
Issue Type: Bug
Components: Wine
Reporter: Oleg Dubinskiy
Assignee: Bug Zilla
Labels: REGRESSION, THEMES
Attachments: comparison 1.png, comparison 2.png
This regression appears if try to check/uncheck squared and circled checkbox buttons. There is incorrect theming when direct mouse cursor on the button and click on it. This problem is actual for any theme, include Lautus, but except Classic theme. It's present since 0.4.9-dev-719. In 718 theming is correct. The difference is visible on comparison images. For example I used Luna and Lautus themes.

...

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[reactosfanboy (JIRA)]

[ https://jira.reactos.org/browse/CORE-14619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

reactosfanboy updated CORE-14619:
---------------------------------
Component/s: Wine
(was: Shell)
Module: uxtheme comctl32 (was: uxtheme)
Labels: REGRESSION THEMES (was: Explorer REGRESSION SHELL32 THEMES)

[b3fb8555bf9abcc04eeac31c7153d33e2f027fc0|https://git.reactos.org/?p=reactos.git;a=commit;h=b3fb8555bf9abcc04eeac31c7153d33e2f027fc0]
[COMCTL32] Sync with Wine Staging 3.3. CORE-14434
cc [~akhaldi]

Checkbox buttons theming regression
-----------------------------------
Key: CORE-14619
URL: https://jira.reactos.org/browse/CORE-14619
Project: Core ReactOS
Issue Type: Bug
Components: Wine
Reporter: Oleg Dubinskiy
Assignee: Bug Zilla
Labels: REGRESSION, THEMES
Attachments: comparison 1.png, comparison 2.png
This regression appears if try to check/uncheck squared and circled checkbox buttons. There is incorrect theming when direct mouse cursor on the button and click on it. This problem is actual for any theme, include Lautus, but except Classic theme. It's present since 0.4.9-dev-719. In 718 theming is correct. The difference is visible on comparison images. For example I used Luna and Lautus themes.

...

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Oleg Dubinskiy (JIRA)]

[ https://jira.reactos.org/browse/CORE-14619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Dubinskiy updated CORE-14619:
----------------------------------
Component/s: Shell
Module: uxtheme
Labels: Explorer REGRESSION SHELL32 THEMES (was: )

Checkbox buttons theming regression
-----------------------------------
Key: CORE-14619
URL: https://jira.reactos.org/browse/CORE-14619
Project: Core ReactOS
Issue Type: Bug
Components: Shell
Reporter: Oleg Dubinskiy
Assignee: Bug Zilla
Labels: Explorer, REGRESSION, SHELL32, THEMES
Attachments: comparison 1.png, comparison 2.png
This regression appears if try to check/uncheck squared and circled checkbox buttons. There is incorrect theming when direct mouse cursor on the button and click on it. This problem is actual for any theme, include Lautus, but except Classic theme. It's present since 0.4.9-dev-719. In 718 theming is correct. The difference is visible on comparison images. For example I used Luna and Lautus themes.

...

--
This message was sent by Atlassian JIRA
(v7.3.2#73013)

[Oleg Dubinskiy (JIRA)]

Oleg Dubinskiy created CORE-14619:
-------------------------------------

Summary: Checkbox buttons theming regression
Key: CORE-14619
URL: https://jira.reactos.org/browse/CORE-14619
Project: Core ReactOS
Issue Type: Bug
Reporter: Oleg Dubinskiy
Assignee: Bug Zilla
Attachments: comparison 1.png, comparison 2.png

This regression appears if try to check/uncheck squared and circled checkbox buttons. There is incorrect theming when direct mouse cursor on the button and click on it. This problem is actual for any theme, include Lautus, but except Classic theme. It's present since 0.4.9-dev-719. In 718 theming is correct. The difference is visible on comparison images. For example I used Luna and Lautus themes.



--
This message was sent by Atlassian JIRA
(v7.3.2#73013)